feat: upgrade Sparkle from 1.27.1 to 2.9.0#235
Merged
Conversation
Replace the deprecated SUUpdater singleton API with Sparkle 2's SPUStandardUpdaterController/SPUUpdater architecture: - Create SPUStandardUpdaterController programmatically in ApplicationController.init instead of XIB-based SUUpdater - Wire "Check for Updates..." menu item via IBOutlet + target/action - Rewrite SparkleObserver to use Combine publishers for canCheckForUpdates and lastUpdateCheckDate - Use SPUUpdater.automaticallyChecksForUpdates property directly instead of writing to UserDefaults - Update "Check Now" button to use canCheckForUpdates (allows manual checks even when auto-check is disabled) - Add SUPublicEDKey placeholder in Info.plist for EdDSA transition (retain SUPublicDSAKeyFile during transition period) - Skip updater initialization in test environment to prevent timeout
2ndalpha
added a commit
that referenced
this pull request
Feb 28, 2026
Replace the XIB-bound right pane (HostsTextView + NSPredicateEditor) with SwiftUI views while keeping the Editor.xib window shell intact. New files: - HostsTextViewRepresentable: NSViewRepresentable wrapping HostsTextView with bidirectional content sync and syntax highlighting preference - CombinedHostsPickerView: SwiftUI toggle list replacing NSPredicateEditor for selecting which hosts files to combine - ContentView: Composes picker (for CombinedHosts) + text editor - ContentInstaller: @objc bridge installing SwiftUI into XIB split view Changes: - HostsTextView: Add createForProgrammaticUse factory method, extract setupColors from initWithCoder for reuse - EditorController: Call ContentInstaller after SidebarInstaller - Bridging header: Add HostsTextView.h import - Xcode project: Add 4 new Swift source files The old controllers (HostsTextController, CombinedHostsPredicateController, CombinedHostsPredicateEditorRowTemplate) remain XIB-instantiated but their views are detached from the hierarchy. Deferred to PR 3 for deletion. This is PR 2 of 3 in the Editor.xib modernization plan.
…erver Replace sink+cancellables with assign(to: &$property) for lastUpdateCheckDate, matching the pattern already used for canCheckForUpdates. Add reactive observation of automaticallyChecksForUpdates so external changes (e.g. Sparkle's first-launch dialog) propagate to the UI.
2ndalpha
added a commit
that referenced
this pull request
Mar 1, 2026
* feat: replace editor right pane with SwiftUI content area (#235) Replace the XIB-bound right pane (HostsTextView + NSPredicateEditor) with SwiftUI views while keeping the Editor.xib window shell intact. New files: - HostsTextViewRepresentable: NSViewRepresentable wrapping HostsTextView with bidirectional content sync and syntax highlighting preference - CombinedHostsPickerView: SwiftUI toggle list replacing NSPredicateEditor for selecting which hosts files to combine - ContentView: Composes picker (for CombinedHosts) + text editor - ContentInstaller: @objc bridge installing SwiftUI into XIB split view Changes: - HostsTextView: Add createForProgrammaticUse factory method, extract setupColors from initWithCoder for reuse - EditorController: Call ContentInstaller after SidebarInstaller - Bridging header: Add HostsTextView.h import - Xcode project: Add 4 new Swift source files The old controllers (HostsTextController, CombinedHostsPredicateController, CombinedHostsPredicateEditorRowTemplate) remain XIB-instantiated but their views are detached from the hierarchy. Deferred to PR 3 for deletion. This is PR 2 of 3 in the Editor.xib modernization plan. * fix: resolve compile errors in HostsTextViewRepresentable and CombinedHostsPickerView - Unwrap optional return from HostsTextView.createForProgrammaticUse (ObjC factory methods return nullable in Swift) - Add @ViewBuilder to pickerContent(for:) to fix opaque return type inference with local let bindings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SUUpdatersingleton API with the modernSPUStandardUpdaterController/SPUUpdaterarchitectureApplicationController.initinstead of via XIBSparkleObserverto use Combine publishers (canCheckForUpdates,lastUpdateCheckDate)SUPublicEDKeyplaceholder in Info.plist for EdDSA signature transitionBefore release
generate_keysfrom Sparkle 2 to create an EdDSA keypairREPLACE_WITH_EDDSA_PUBLIC_KEYin Info.plist with the real public keyTest plan